Bump rubocop-govuk and rubocop-rspec #3310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahcrack
force-pushed
the
bump-rubocop-rspec
branch
from
83c74d0 to
b84961a
Compare
|
Review app deployed to https://get-school-experience-review-pr-3310.test.teacherservices.cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/9khhgFim/6955-dependency-updates-on-get-school-experience-rubocop-shakapacker-and-babel
Context
The
rubocop-govukupdate involved breaking changes related to other dependencies which meant tests were failing. Therubocop-govukbump was originally part of this dependabot update.Changes proposed in this pull request
rubocop-govukto 5.0.2.gem 'rubocop-capybara', '~> 2.21',gem 'rubocop-factory_bot', '~> 2.26',gem 'rubocop-rspec', '~> 3.2'.rubocop.ymlfile..rubocop_todo.ymllist for linting errors; the past offences will now be ignored by Rubocop, therefore all tests are currently passing. Question as to how/when to address these errors in future (due to the nature/age of GSE, there are over 6,000 offences at present).Guidance to review